Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): expose uri method for Dataset instance #3231

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

yanghua
Copy link
Collaborator

@yanghua yanghua commented Dec 11, 2024

No description provided.

@github-actions github-actions bot added enhancement New feature or request java labels Dec 11, 2024
@yanghua
Copy link
Collaborator Author

yanghua commented Dec 11, 2024

cc @westonpace @wjones127

Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much of the Java API but I agree this is a good idea. We expose the dataset URI in Rust and Python.

@LuQQiu any opinion?

@wjones127 wjones127 merged commit d5afc0a into lancedb:main Dec 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants