feat: support blob api in pytorch loader #3217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6188fa to
8e4082a
Compare
chebbyChefNEQ
approved these changes
Dec 8, 2024
| @@ -234,6 +243,10 @@ def __init__( | |||
| self._to_tensor_fn = to_tensor_fn | |||
| self._hf_converter = None | |||
|
|
|||
| self._blob_columns = self._blob_columns() | |||
| if self._blob_columns: | |||
| self.with_row_id = True | |||
There was a problem hiding this comment.
we need row id to call dataset.take_blobs()
python/python/lance/torch/data.py
Outdated
| arr: pa.Array = batch[col] | ||
|
|
||
| if isinstance(arr, list) and arr and isinstance(arr[0], lance.BlobFile): |
There was a problem hiding this comment.
Is there a way to check earlier? Like when constructing the loader?
There was a problem hiding this comment.
Yes we probably can. One way to do it is passing more parameters, but it makes user-specified to_tensor_fn more complicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support handling Blob data in PyTorch loader