Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: full text search may produce dup results when search over multiple columns #3189

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

BubbleCal
Copy link
Contributor

fix #3188

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions bot added the bug Something isn't working label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@BubbleCal BubbleCal changed the title fix: FTS may produce dup results when search over multiple columns fix: full text search may produce dup results when search over multiple columns Dec 2, 2024
Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 78.71%. Comparing base (dc9afbb) to head (d97469d).

Files with missing lines Patch % Lines
rust/lance/src/dataset/scanner.rs 73.33% 1 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3189      +/-   ##
==========================================
+ Coverage   78.06%   78.71%   +0.64%     
==========================================
  Files         243      243              
  Lines       82661    82694      +33     
  Branches    82661    82694      +33     
==========================================
+ Hits        64529    65090     +561     
+ Misses      14932    14825     -107     
+ Partials     3200     2779     -421     
Flag Coverage Δ
unittests 78.71% <75.00%> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BubbleCal BubbleCal requested a review from wjones127 December 2, 2024 11:07
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix looks good. The CI failure looks like it's an issue on main. I'll investigate that soon.

@BubbleCal BubbleCal marked this pull request as ready for review December 3, 2024 03:51
@BubbleCal BubbleCal merged commit dc8f0f6 into lancedb:main Dec 3, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: FTS gives duplicate results if searching over multiple columns
3 participants