Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: panic if all docs are deleted in a posting list #3163

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

BubbleCal
Copy link
Contributor

fix #3012

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@github-actions github-actions bot added bug Something isn't working python labels Nov 23, 2024
@BubbleCal BubbleCal marked this pull request as ready for review November 23, 2024 03:27
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.00%. Comparing base (d79e870) to head (4e8227f).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3163      +/-   ##
==========================================
+ Coverage   77.95%   78.00%   +0.05%     
==========================================
  Files         242      243       +1     
  Lines       82436    82834     +398     
  Branches    82436    82834     +398     
==========================================
+ Hits        64262    64614     +352     
- Misses      14960    15006      +46     
  Partials     3214     3214              
Flag Coverage Δ
unittests 78.00% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@BubbleCal BubbleCal merged commit 196ec06 into lancedb:main Nov 25, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTS search error: pivot posting should have at least one document
3 participants