Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle filter on empty partition #3151

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Nov 21, 2024

It panicked when it applies filter on an empty partition

thread 'index::vector::pq::tests::test_filter_on_empty_pq_code' panicked at rust/lance/src/index/vector/pq.rs:125:14:
chunk size must be non-zero

@github-actions github-actions bot added the bug Something isn't working label Nov 21, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 48.38710% with 16 lines in your changes missing coverage. Please review.

Project coverage is 77.86%. Comparing base (8069936) to head (451d4c0).

Files with missing lines Patch % Lines
rust/lance/src/index/vector/pq.rs 48.38% 15 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3151      +/-   ##
==========================================
- Coverage   77.89%   77.86%   -0.04%     
==========================================
  Files         242      242              
  Lines       82183    82214      +31     
  Branches    82183    82214      +31     
==========================================
- Hits        64020    64016       -4     
- Misses      14973    14979       +6     
- Partials     3190     3219      +29     
Flag Coverage Δ
unittests 77.86% <48.38%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@eddyxu eddyxu merged commit 920b191 into main Nov 21, 2024
29 checks passed
@eddyxu eddyxu deleted the lei/filter_empty_partition branch November 21, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants