-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: merge-insert supports inserting subset of columns #3100
feat: merge-insert supports inserting subset of columns #3100
Conversation
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
50bcf3a
to
e7a79cf
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3100 +/- ##
==========================================
- Coverage 78.97% 78.91% -0.06%
==========================================
Files 246 246
Lines 86313 86560 +247
Branches 86313 86560 +247
==========================================
+ Hits 68162 68311 +149
- Misses 15328 15421 +93
- Partials 2823 2828 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
) -> Result<usize> { | ||
// Batches still have _rowaddr (used elsewhere to merge with existing data) | ||
// We need to remove it before writing to Lance files. | ||
let num_fields = batches[0].schema().fields().len(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not needed for this PR but we should add a drop columns method to schema.
In #2639 we added support for updating subcolumns. In #3041 we added support for inserting subcolumns. This PR adds support for upserting them (or doing insert-if-not-exists).
Closes #2904
Example