perf: use total cmp for ordered float #3059
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR:
PartialOrd
impl forf32
requires two cmp instructions andPartialOrd::lt
is not reduced to a single instruction. Withtotal_cmp
we avoid this overhead. See https://godbolt.org/z/ez4EaEs3WNote: maybe we could gain more perf by implementing a
NaN-less
cmp?V1:
V3 before perf fix
V3 after perf fix