fix: fix the incorrect assertion for fixed size binary decoder #3050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
cfa354b to
dffa4d8
Compare
niyue
commented
Oct 26, 2024
| @@ -84,7 +84,7 @@ impl PrimitivePageDecoder for FixedSizeBinaryDecoder { | |||
| let num_bytes = num_rows * self.byte_width; | |||
| let bytes = self.bytes_decoder.decode(rows_to_skip, num_bytes)?; | |||
| let bytes = bytes.as_fixed_width().unwrap(); | |||
| debug_assert_eq!(bytes.bits_per_value, 8); | |||
| debug_assert_eq!(bytes.bits_per_value, self.byte_width * 8); | |||
There was a problem hiding this comment.
This decoder will be used if Lance format 2.1 is enabled and this assertion will fail for some input data.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3050 +/- ##
==========================================
+ Coverage 78.40% 78.42% +0.02%
==========================================
Files 240 240
Lines 78593 78637 +44
Branches 78593 78637 +44
==========================================
+ Hits 61617 61669 +52
+ Misses 13851 13825 -26
- Partials 3125 3143 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…test to verify the fixed size binary decoder really works.
dffa4d8 to
0bc992d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to fix #3049
It fixes the incorrect assertion for fixed size binary decoder and add a test to verify fixed size binary decoder works.