Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: fix confusing impl of indexed_fragments #3047

Merged

Conversation

wjones127
Copy link
Contributor

The reference to total_fragment_bitmap made no sense. This PR eliminates that, and also fixes very minor inefficiencies.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 78.39%. Comparing base (536e73d) to head (5991d35).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/index.rs 86.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3047      +/-   ##
==========================================
+ Coverage   78.38%   78.39%   +0.01%     
==========================================
  Files         240      240              
  Lines       77122    78592    +1470     
  Branches    77122    78592    +1470     
==========================================
+ Hits        60449    61614    +1165     
- Misses      13565    13862     +297     
- Partials     3108     3116       +8     
Flag Coverage Δ
unittests 78.39% <86.66%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 merged commit 4812ac0 into lancedb:main Oct 28, 2024
23 checks passed
@wjones127 wjones127 deleted the refactor/simplify-delta-fragment-count branch October 28, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants