fix

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
lancedb · BubbleCal · Oct 31, 2024 · Oct 19, 2024 · Oct 21, 2024 · Oct 22, 2024
commit 79082cb698c7457bb876e722d26253d88c0d7a5d
diff --git a/rust/lance-index/src/scalar/inverted/index.rs b/rust/lance-index/src/scalar/inverted/index.rs
@@ -1007,6 +1007,7 @@ fn do_flat_full_text_search<Offset: OffsetSizeTrait>(
     Ok(results)
 }
 
+#[allow(clippy::too_many_arguments)]
 pub fn flat_bm25_search(
     batch: RecordBatch,
     doc_col: &str,
@@ -1017,7 +1018,7 @@ pub fn flat_bm25_search(
     avgdl: f32,
     num_docs: usize,
 ) -> std::result::Result<RecordBatch, DataFusionError> {
-    let doc_iter = iter_str_array(&batch[&doc_col]);
+    let doc_iter = iter_str_array(&batch[doc_col]);
     let mut scores = Vec::with_capacity(batch.num_rows());
     for doc in doc_iter {
         let doc = match doc {
@@ -1057,7 +1058,7 @@ pub fn flat_bm25_search(
 
     let score_col = Arc::new(Float32Array::from(scores)) as ArrayRef;
     let batch = batch
-        .drop_column(&doc_col)?
+        .drop_column(doc_col)?
         .try_with_column(SCORE_FIELD.clone(), score_col)?;
     Ok(batch)
 }

diff --git a/rust/lance-io/src/object_store.rs b/rust/lance-io/src/object_store.rs
    pub fn remove_stream<'a>(
        &'a self,
        locations: BoxStream<'a, Result<Path>>,
    ) -> BoxStream<Result<Path>> {
        self.inner
            .delete_stream(locations.err_into::<ObjectStoreError>().boxed())
            .err_into::<Error>()
diff --git a/rust/lance-file/src/writer/statistics.rs b/rust/lance-file/src/writer/statistics.rs

 fn cast_dictionary_arrays<'a, T: ArrowDictionaryKeyType + 'static>(
    arrays: &'a [&'a ArrayRef],
 ) -> Vec<&Arc<dyn Array>> {
    arrays
        .iter()
        .map(|x| x.as_dictionary::<T>().values())
diff --git a/rust/lance-index/src/scalar/label_list.rs b/rust/lance-index/src/scalar/label_list.rs
    fn search_values<'a>(
        &'a self,
        values: &'a Vec<ScalarValue>,
    ) -> BoxStream<Result<RowIdTreeMap>> {
        futures::stream::iter(values)
            .then(move |value| {
                let value_query = SargableQuery::Equals(value.clone());
	pub fn remove_stream<'a>(
	&'a self,
	locations: BoxStream<'a, Result<Path>>,
	) -> BoxStream<Result<Path>> {
Check warning on line 638 in rust/lance-io/src/object_store.rs GitHub Actions / linux-build (nightly) `elided lifetime has a name`
	self.inner
	.delete_stream(locations.err_into::<ObjectStoreError>().boxed())
	.err_into::<Error>()

	fn cast_dictionary_arrays<'a, T: ArrowDictionaryKeyType + 'static>(
	arrays: &'a [&'a ArrayRef],
	) -> Vec<&Arc<dyn Array>> {
Check warning on line 489 in rust/lance-file/src/writer/statistics.rs GitHub Actions / linux-build (nightly) `elided lifetime has a name`
	arrays
	.iter()
	.map(\|x\| x.as_dictionary::<T>().values())
	fn search_values<'a>(
	&'a self,
	values: &'a Vec<ScalarValue>,
	) -> BoxStream<Result<RowIdTreeMap>> {
Check warning on line 81 in rust/lance-index/src/scalar/label_list.rs GitHub Actions / linux-build (nightly) `elided lifetime has a name`
	futures::stream::iter(values)
	.then(move \|value\| {
	let value_query = SargableQuery::Equals(value.clone());