Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create FTS on empty table/strings #3024

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

BubbleCal
Copy link
Contributor

fix #3013

Signed-off-by: BubbleCal <bubble-cal@outlook.com>
@BubbleCal BubbleCal requested a review from wjones127 October 19, 2024 08:24
@github-actions github-actions bot added the bug Something isn't working label Oct 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.41%. Comparing base (f9024ce) to head (dd7fc2c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3024      +/-   ##
==========================================
+ Coverage   78.19%   78.41%   +0.21%     
==========================================
  Files         239      239              
  Lines       76782    76853      +71     
  Branches    76782    76853      +71     
==========================================
+ Hits        60043    60264     +221     
+ Misses      13669    13496     -173     
- Partials     3070     3093      +23     
Flag Coverage Δ
unittests 78.41% <100.00%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BubbleCal BubbleCal marked this pull request as ready for review October 19, 2024 11:10
@wjones127 wjones127 merged commit 038f239 into lancedb:main Oct 21, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FTS search error on empty table: panicked with message "assertion left == right failed
3 participants