Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update cursor correctly in blob file API #3018

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

westonpace
Copy link
Contributor

When read returns it should update the cursor to the end of the data just read. However, we were calculating this as end and not end - position.

The cursor is supposed to be relative to the start of the blob in the file (e.g. 0 == position).

Copy link

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.25%. Comparing base (631e9bf) to head (8c78e8f).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/dataset/blob.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3018      +/-   ##
==========================================
+ Coverage   78.22%   78.25%   +0.02%     
==========================================
  Files         239      239              
  Lines       76576    76712     +136     
  Branches    76576    76712     +136     
==========================================
+ Hits        59902    60029     +127     
+ Misses      13626    13610      -16     
- Partials     3048     3073      +25     
Flag Coverage Δ
unittests 78.25% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace changed the title feature: fix minor bug in blob file API fix: update cursor correctly in blob file API Oct 17, 2024
@github-actions github-actions bot added the bug Something isn't working label Oct 17, 2024
@westonpace westonpace merged commit f9024ce into lancedb:main Oct 18, 2024
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants