Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rust): add checkout_latest to Dataset #2991

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

wjones127
Copy link
Contributor

This is faster than doing dataset.checkout_version(dataset.latest_version_id().await?).await?, since we don't need to do an extra IOP to get the size and manifest path style of the version. (We do this in LanceDB right now.)

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 78.84%. Comparing base (fdbe4a8) to head (4081afe).

Files with missing lines Patch % Lines
rust/lance/src/dataset.rs 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2991      +/-   ##
==========================================
- Coverage   78.84%   78.84%   -0.01%     
==========================================
  Files         236      236              
  Lines       73552    73556       +4     
  Branches    73552    73556       +4     
==========================================
+ Hits        57995    57997       +2     
+ Misses      12553    12549       -4     
- Partials     3004     3010       +6     
Flag Coverage Δ
unittests 78.84% <75.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wjones127 wjones127 merged commit 003edbe into lancedb:main Oct 9, 2024
21 of 22 checks passed
@wjones127 wjones127 deleted the feat/checkout-latest branch October 9, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants