-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support storage options for spark read and write #2990
feat: support storage options for spark read and write #2990
Conversation
ACTION NEEDED The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. For details on the error please inspect the "PR Title Check" action. |
@SaintBacchus thanks for contributing to the Java API! Awesome! Could you help fix the "cargo clippy --all-targets -- -D warnings" errors shown in the test https://github.com/lancedb/lance/actions/runs/11254749789/job/31292838444?pr=2990 |
import java.util.HashMap; | ||
import java.util.Map; | ||
|
||
public class SparkOptions { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we put SparkOptions inside LanceConfig?
LanceConfig is expected to be the centralized place of putting Spark related configuration.
It can have Optional of ReadOptions and Optional of WriteParams?
74fda65
to
42983d0
Compare
OK, I will fix the ut later. |
cfbd09a
to
14deaf9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#2854
Set storage options configuration in spark-default
Then you can read and write lance file for object store.