Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add python benchmark test for write/read integers #2940

Merged
merged 4 commits into from
Oct 3, 2024

Conversation

broccoliSpicy
Copy link
Contributor

Copy link

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@broccoliSpicy broccoliSpicy changed the title add python benchmark test for write/read integers(draft, wip) add python benchmark test for write/read integers Sep 27, 2024
@broccoliSpicy broccoliSpicy changed the title add python benchmark test for write/read integers perf: add python benchmark test for write/read integers Oct 1, 2024
Copy link
Contributor

@westonpace westonpace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for expanding this. It's a lot of information and I'd prefer it someday go through something like pytest-benchmark as that would make it easier to fit into a reporting system.

However, I think that can wait for now. Best to just treat this as an internal development tool and not something for regression / benchmarking until we're ready.

@broccoliSpicy
Copy link
Contributor Author

It's a lot of information and I'd prefer it someday go through something like pytest-benchmark as that would make it easier to fit into a reporting system.

sorry, the benchmark results csv file are accidentally git added, I think they should be keep out of lance repository and removed it.

yeah, these tests should be made into pytest-benchmark later

@westonpace
Copy link
Contributor

Agreed, thanks :)

Feel free to merge

@broccoliSpicy broccoliSpicy merged commit a386edd into lancedb:main Oct 3, 2024
11 checks passed
@broccoliSpicy broccoliSpicy deleted the python_integer_benchmark branch October 16, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants