Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: postfilter should be applied in full if knn/fts even if scalar index applies #2931

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

westonpace
Copy link
Contributor

If we are in a post-filtering situation (ann/knn/fts) and there is a scalar index that can be applied to the filter then the scalar index part was being skipped.

This also fixes a bug where we would consider btree/bitmap indices when trying to auto-pick the FTS column.

@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2024

Codecov Report

Attention: Patch coverage is 52.94118% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.79%. Comparing base (47eb00e) to head (8cb11e0).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/dataset/scanner.rs 38.46% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2931      +/-   ##
==========================================
+ Coverage   77.75%   77.79%   +0.03%     
==========================================
  Files         231      231              
  Lines       70485    70593     +108     
  Branches    70485    70593     +108     
==========================================
+ Hits        54805    54915     +110     
- Misses      12769    12775       +6     
+ Partials     2911     2903       -8     
Flag Coverage Δ
unittests 77.79% <52.94%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit baacc63 into lancedb:main Sep 27, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants