Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use existing storage version on overwrite, if none specified #2924

Merged

Conversation

westonpace
Copy link
Contributor

This was supposed to be the logic but was not tested and was not being used correctly.

@github-actions github-actions bot added bug Something isn't working python labels Sep 23, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.84%. Comparing base (ea78168) to head (213e9bc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2924      +/-   ##
==========================================
+ Coverage   77.83%   77.84%   +0.01%     
==========================================
  Files         231      231              
  Lines       70199    70259      +60     
  Branches    70199    70259      +60     
==========================================
+ Hits        54636    54690      +54     
- Misses      12691    12693       +2     
- Partials     2872     2876       +4     
Flag Coverage Δ
unittests 77.84% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@westonpace westonpace merged commit f48e970 into lancedb:main Sep 23, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants