Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support decimal 128 and 256 json types #2880

Merged
merged 3 commits into from
Sep 14, 2024
Merged

Conversation

LuQQiu
Copy link
Contributor

@LuQQiu LuQQiu commented Sep 13, 2024

Fix: #2872

@github-actions github-actions bot added the enhancement New feature or request label Sep 13, 2024
Copy link

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.89%. Comparing base (60797a6) to head (fc74ffe).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
rust/lance/src/arrow/json.rs 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2880      +/-   ##
==========================================
+ Coverage   77.87%   77.89%   +0.01%     
==========================================
  Files         231      231              
  Lines       70513    70528      +15     
  Branches    70513    70528      +15     
==========================================
+ Hits        54915    54939      +24     
+ Misses      12465    12456       -9     
  Partials     3133     3133              
Flag Coverage Δ
unittests 77.89% <83.33%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eddyxu eddyxu changed the title feat: Support decimal 128 256 json types feat: support decimal 128 and 256 json types Sep 14, 2024
@eddyxu eddyxu merged commit c0e966c into lancedb:main Sep 14, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: support convert Decimal128 to json
3 participants