Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): add dataset open storage options #2871

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

LuQQiu
Copy link
Contributor

@LuQQiu LuQQiu commented Sep 12, 2024

Add dataset open storage options to support connecting to S3
#2854

@LuQQiu
Copy link
Contributor Author

LuQQiu commented Sep 12, 2024

TODO S3 testing

@github-actions github-actions bot added enhancement New feature or request java labels Sep 12, 2024
Copy link

ACTION NEEDED
Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@LuQQiu LuQQiu changed the title feat(java): Add dataset open storage options feat(java): add dataset open storage options Sep 13, 2024
@LuQQiu
Copy link
Contributor Author

LuQQiu commented Sep 13, 2024

Relates to #2854 Didn't get time to test it. Feel free to take over the PR or issue

@LuQQiu LuQQiu merged commit 2c13945 into lancedb:main Sep 18, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request java
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants