-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: change the default data storage version to "stable" (e.g. v2.0) #2829
feat!: change the default data storage version to "stable" (e.g. v2.0) #2829
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2829 +/- ##
==========================================
+ Coverage 78.04% 78.11% +0.06%
==========================================
Files 229 229
Lines 70357 70492 +135
Branches 70357 70492 +135
==========================================
+ Hits 54911 55064 +153
+ Misses 12361 12315 -46
- Partials 3085 3113 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
359a686
to
1b6a331
Compare
1b6a331
to
51fb149
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably state the earliest version of Lance that can read these new V2 files. I think we are breaking a certain backwards compatibility by changing the default, right?
Backwards compatibility, no, I don't think so. We won't lose any capability to read older files. Forwards compatibility: kind of. This only applies the v2 default to new datasets. So old readers will continue to be able to read old datasets but yes, readers beyond a certain point (probably 0.16 to be safe but in reality maybe even older) will not be able to read new datasets created by new versions. I'll update some docs somewhere. |
1b1258d
to
e7cef55
Compare
I've marked this a breaking change. I verified that we have a "minimum lance version" in the format section (and updated it from 0.15 to 0.16). I've added some basic "future compatibility" tests to make sure we can, in fact, read lance files written with the latest version in 0.16. |
- name: Run forward compatibility tests | ||
run: | | ||
source venv/bin/activate | ||
pytest python/tests/forward_compat --run-forward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fancy! ✨
python/python/tests/test_dataset.py
Outdated
|
||
dataset = lance.dataset(base_dir) | ||
|
||
print(format_fragment(dataset.get_fragment(0).metadata, dataset)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we be keeping this print?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. Removed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, do we support pushdown in V2 yet? Is that coming soon?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Soon? I'll try and work on that next once I'm done with this mini-block stuff.
e7cef55
to
321e56d
Compare
Forgot to increment the version in #2829
Closes #2394
This PR changes a few remaining tests. Also, by changing the default to v2 we exposed a few minor inconsistencies with v1 that we fixed.
BREAKING CHANGE: new datasets will no longer be readable by versions older than 0.16