-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: convert encoders to use data blocks #2817
refactor: convert encoders to use data blocks #2817
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor suggestions, all others looks good to me.
1d35ff8
to
7c69ed2
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2817 +/- ##
==========================================
- Coverage 78.12% 77.88% -0.25%
==========================================
Files 229 231 +2
Lines 70492 70373 -119
Branches 70492 70373 -119
==========================================
- Hits 55073 54807 -266
- Misses 12305 12444 +139
- Partials 3114 3122 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The recent encodings refactor #2817 broke our ability to write fixed size list arrays of nullable values (we could still handle nullable fixed size list arrays). This PR restores the capability.
This is the last of the refactors needed to convert the encoders to working with data blocks.