Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support storage options in write fragments #2289

Merged
merged 1 commit into from
May 2, 2024

Conversation

eddyxu
Copy link
Contributor

@eddyxu eddyxu commented May 2, 2024

Closes #2154

@eddyxu eddyxu requested review from westonpace and wjones127 May 2, 2024 20:03
@github-actions github-actions bot added the enhancement New feature or request label May 2, 2024
Copy link

github-actions bot commented May 2, 2024

ACTION NEEDED

Lance follows the Conventional Commits specification for release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

For details on the error please inspect the "PR Title Check" action.

@eddyxu eddyxu changed the title feat: support storage options in write fragments feat: support storage options in write fragments May 2, 2024
Copy link
Contributor

@wjones127 wjones127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that was easy 🤣

@eddyxu eddyxu merged commit dd7256d into main May 2, 2024
11 of 14 checks passed
@eddyxu eddyxu deleted the lei/write_fragment_storage_options branch May 2, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose storage_options in write_fragments
2 participants