Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repair the filter keyword in the torch dataset loader #1935

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

westonpace
Copy link
Contributor

When support was added for sampling in #1900 it broke support for filtering on full scans (sampling and filtering is not yet supported). This PR repairs support for filtering on full scans.

Closes #1932

@westonpace westonpace requested a review from eddyxu February 9, 2024 17:07
@westonpace westonpace merged commit 873e02a into lancedb:main Feb 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

torch LanceDataset appears to be ignoring filter
2 participants