Use interruptGuard in VThreadScheduler #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
reviewed
Jan 4, 2024
| @@ -13,11 +14,14 @@ object VThreadScheduler extends Scheduler: | |||
| override def execute(body: Runnable): Unit = VTFactory.newThread(body) | |||
|
|
|||
| override def schedule(delay: FiniteDuration, body: Runnable): Cancellable = | |||
| val interruptGuard = AtomicBoolean(true) // to avoid interrupting the body | |||
There was a problem hiding this comment.
Great but use varHandle to reduce memory usage？
There was a problem hiding this comment.
@He-Pin can you elaborate?
There was a problem hiding this comment.
Like atomic interger field updater, which can reduce the 4byte ref of the object wrapper.
|
@m8nmueller @He-Pin I implemented the VarHandle approach, please have a look. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
He-Pin
reviewed
Jan 22, 2024
He-Pin
reviewed
Jan 22, 2024
He-Pin
reviewed
Jan 22, 2024
He-Pin
suggested changes
Jan 22, 2024
He-Pin
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple solution to this double scheduling. Allocate
AtomicBooleanvs a new virtual thread.Happy New Year! 🎉