Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix the floating-point values are incorrectly read using the finslib_multiple_memory_area_read() function #24

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Try to fix the floating-point values are incorrectly read using the finslib_multiple_memory_area_read() function #24

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da60672
Fix the byte order parsing for single floating-point number errors.
Sep 18, 2024
ba4a1ba
Fix the byte order parsing for double floating-point number errors. A…
Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/fins_01_04.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,10 +332,10 @@ int finslib_multiple_memory_area_read( struct fins_sys_tp *sys, struct fins_mult

case FINS_DATA_TYPE_FLOAT :

sfloat.val_raw[0] = fins_cmnd.body[0];
sfloat.val_raw[1] = fins_cmnd.body[1];
sfloat.val_raw[2] = fins_cmnd.body[3];
sfloat.val_raw[3] = fins_cmnd.body[4];
sfloat.val_raw[0] = fins_cmnd.body[bodylen+1];
sfloat.val_raw[1] = fins_cmnd.body[bodylen+0];
sfloat.val_raw[2] = fins_cmnd.body[bodylen+4];
sfloat.val_raw[3] = fins_cmnd.body[bodylen+3];

item[offset+a].sfloat = sfloat.val_float;

Expand All @@ -347,14 +347,14 @@ int finslib_multiple_memory_area_read( struct fins_sys_tp *sys, struct fins_mult

case FINS_DATA_TYPE_DOUBLE :

dfloat.val_raw[0] = fins_cmnd.body[0];
dfloat.val_raw[1] = fins_cmnd.body[1];
dfloat.val_raw[2] = fins_cmnd.body[3];
dfloat.val_raw[3] = fins_cmnd.body[4];
dfloat.val_raw[4] = fins_cmnd.body[6];
dfloat.val_raw[5] = fins_cmnd.body[7];
dfloat.val_raw[6] = fins_cmnd.body[9];
dfloat.val_raw[7] = fins_cmnd.body[10];
dfloat.val_raw[0] = fins_cmnd.body[bodylen+1];
dfloat.val_raw[1] = fins_cmnd.body[bodylen+0];
dfloat.val_raw[2] = fins_cmnd.body[bodylen+4];
dfloat.val_raw[3] = fins_cmnd.body[bodylen+3];
dfloat.val_raw[4] = fins_cmnd.body[bodylen+7];
dfloat.val_raw[5] = fins_cmnd.body[bodylen+6];
dfloat.val_raw[6] = fins_cmnd.body[bodylen+10];
dfloat.val_raw[7] = fins_cmnd.body[bodylen+9];

item[offset+a].dfloat = dfloat.val_double;

Expand Down