Drop support for PHP 8.1, Upgrade Psalm to v6 & PHPUnit to v11 #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes some unnecessary Psalm plugins - General SA QA Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
…pectations Signed-off-by: George Steel <george@net-glue.co.uk>
Signed-off-by: George Steel <george@net-glue.co.uk>
gsteel
commented
Jan 26, 2025
| * @phpcs:disable Generic.Files.LineLength.TooLong | ||
| * @param class-string<FactoryInterface>|class-string<object&FactoryCallable>|FactoryCallable|FactoryInterface $factory | ||
| * @phpcs:enable Generic.Files.LineLength.TooLong | ||
| * @param class-string<FactoryInterface>|FactoryCallable|FactoryInterface $factory |
There was a problem hiding this comment.
Using intersections with callable in a class string parameter is not supported, i.e. class-string<object&callable> causes an InvalidDocblock issue in Psalm
| * @phpcs:disable Generic.Files.LineLength.TooLong | ||
| * @psalm-param class-string<DelegatorFactoryInterface>|class-string<object&DelegatorCallable>|DelegatorCallable $factory | ||
| * @phpcs:enable Generic.Files.LineLength.TooLong | ||
| * @psalm-param class-string<DelegatorFactoryInterface>|DelegatorCallable $factory |
There was a problem hiding this comment.
Using intersections with callable in a class string parameter is not supported, i.e. class-string<object&callable> causes an InvalidDocblock issue in Psalm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an alternative to changes made in #252 , try upgrading to Psalm v6 to see if callable intersections in parameterized class-strings work now.Also,