Provide PHP 8.1 support #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
reviewed
Sep 14, 2021
|
It seems php 8.1, with latest phpstan, it still error: PHP Fatal error: During inheritance of ArrayAccess: Uncaught Return type of Hoa\Protocol\Node\Node::offsetExists($name) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice
phar:///github/workspace/vendor/phpstan/phpstan/phpstan.phar/vendor/hoa/protocol/Node/Node.php:134 |
|
PHP 8.1 error possibly related with this phpstan/phpstan#5558 |
|
Also related: Roave/BetterReflection#701 |
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
f9b02f7 to
83e2f18
Compare
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
83e2f18 to
89e0ab6
Compare
|
rebased and re-generated composer.lock from php 7.4 |
|
@Ocramius All green 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abdul Malik Ikhsan samsonasik@gmail.com
.laminas-ci.json