Helper optional renderer consistency #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksei Khudiakov <aleksey@xerkus.pro>
….x_MkCXLtZO Merge release 3.19.1 into 3.20.x
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…nder a hidden field Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
…rmSelect if needed Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
froschdesign
reviewed
Feb 5, 2024
Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
Slamdunk
requested changes
Feb 8, 2024
Signed-off-by: Paul McGarry <paul@paulmcgarry.com>
Slamdunk
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Inconsistencies in the way different view helpers load plugins meant that while most helpers worked without a renderer being attached on $this->view, a few failed.
This PR brings the few cases where plugins weren't successfully created when $this->view wasn't populated into line with the others and includes unit tests that fail before the change.
Arguably?
In some older versions of PHP (ie 7.4) some of these cases (eg FormSelect::getFormHiddenHelper()) would work (because $this->view being null only became a TypeError for method_exists() in PHP 8.0) and then stopped working on current PHP versions.
So these fixes would make code that worked for people under older versions of PHP continue to work as they uplift their PHP and Laminas versions.
There is a little background on:
https://discourse.laminas.dev/t/laminas-form-view-helper-retrieval-consistency/3591