Non-variadic parameter should not throw exception when calling ParameterGenerator#setVariadic(false) with an existing default value
#173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setVariadic should only throw exception when parameter is variadic and has default value. Signed-off-by: sakhunzai <sakhunzai@users.noreply.github.com>
Non variadic parameter should not throw exception when having default value Signed-off-by: sakhunzai <sakhunzai@users.noreply.github.com>
remote whitespaces Signed-off-by: sakhunzai <sakhunzai@users.noreply.github.com>
remote whitespaces Signed-off-by: sakhunzai <sakhunzai@users.noreply.github.com>
Ocramius
requested changes
Mar 3, 2023
added generated code expectation Signed-off-by: sakhunzai <sakhunzai@users.noreply.github.com>
|
please review changes |
Ocramius
approved these changes
Mar 4, 2023
ParameterGenerator#setVariadic(false) with an existing default value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the changes introduce in PR #72 by ensuring call to
setVariadicshould not throw exception when parameter is non variadic.