Remove deprecated set-output action commands

[gsteel]

actions/core is already at ^1.10 so only the workflows require updating to use the new environment files

Closes #147

[Ocramius]

LGTM, but I don't really know what's going on under the hood :D

Asked for more reviews.

[gsteel]

Looks to me that all the remaining notices for set-output come from sergeysova/jq-action@v2 - a patch exists for that here: sergeysova/jq-action#9

[samsonasik]

If there is possibly multiline with some escaping, the change seems needs to be something like:

        run: |
          echo "log<<MESSAGE" >> $GITHUB_OUTPUT
          echo "$(some_data)" >> $GITHUB_OUTPUT
          echo 'MESSAGE' >> $GITHUB_OUTPUT

ref

• https://github.com/phpstan/phpstan-src/pull/1917/files#diff-39c7f1bcfed19e41d56b6260c66af6d03da1257d053b371b7c0de3a3ed01bb13
• https://github.com/rectorphp/rector-src/pull/3016/files

[gsteel]

@samsonasik shell-check seems OK with the changed lines - is there something specific that looks wrong? Won't single quotes break the expansions?

[samsonasik]

@gsteel probably if there is some special chars like in PHPStan, which when combining with multiline, may break the workflow:

Run echo "log=$(git log c2ef009c67198d39a6e685a1bca21ceab798d35b..fec8acc849277c78755d3d00767eff95ed3c4014 --reverse --pretty='%H %s' | sed -e 's/^/https:\/\/github.com\/phpstan\/phpstan-src\/commit\//')" >> $GITHUB_OUTPUT
Error: Unable to process file command 'output' successfully.

ref https://github.com/phpstan/phpstan-src/actions/runs/3320826153/jobs/5487697232#step:6:1

The multiline example is at https://docs.github.com/en/actions/using-workflows/workflow-commands-for-github-actions#example-2

[gsteel]

Thanks @samsonasik - I understand now! None of the changed lines output multiline. The CI workflow which dumps a load of json is single line too: https://github.com/laminas/laminas-ci-matrix-action/actions/runs/3460149728/jobs/5776368483#step:3:2

[samsonasik]

Ok then 👍

[boesing]

Can only tell that tests seem to run, therefore I guess it works for the continuous-integration plan.
Not sure if it works properly for the tag stuff regarding container creation, no idea how to test that.

[internalsystemerror]

Not too familiar with the quirks of GHA, but reading through the changelog, everything here is as they suggest so 👍

[Ocramius]

Nobody presses the bad green button? I'll do it then :P