Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Invalid characters passed for attempted conversion (7.4) #2

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Fix Invalid characters passed for attempted conversion (7.4) #2

merged 1 commit into from
Jan 24, 2020

Conversation

remicollet
Copy link
Contributor

@remicollet remicollet commented Jan 2, 2020 •
edited
Loading

Running test suite with PHP 7.4.1

There were 36 errors:

1) ZendTest\Barcode\Object\CodabarTest::testForeColor
Invalid characters passed for attempted conversion, these have been ignored

/dev/shm/BUILDROOT/php-zendframework-zend-barcode-2.8.0-1.fc31.remi.x86_64/usr/share/php/Zend/Barcode/Object/AbstractObject.php:432
/dev/shm/BUILD/zend-barcode-6db95687997920b8217e71d2f12b51ec10e824d9/test/Object/TestCommon.php:160

2) ZendTest\Barcode\Object\CodabarTest::testBackgroundColor
Invalid characters passed for attempted conversion, these have been ignored

/dev/shm/BUILDROOT/php-zendframework-zend-barcode-2.8.0-1.fc31.remi.x86_64/usr/share/php/Zend/Barcode/Object/AbstractObject.php:463
/dev/shm/BUILD/zend-barcode-6db95687997920b8217e71d2f12b51ec10e824d9/test/Object/TestCommon.php:180

3) ZendTest\Barcode\Object\Code128Test::testForeColor
Invalid characters passed for attempted conversion, these have been ignored

/dev/shm/BUILDROOT/php-zendframework-zend-barcode-2.8.0-1.fc31.remi.x86_64/usr/share/php/Zend/Barcode/Object/AbstractObject.php:432
/dev/shm/BUILD/zend-barcode-6db95687997920b8217e71d2f12b51ec10e824d9/test/Object/TestCommon.php:160

4) ZendTest\Barcode\Object\Code128Test::testBackgroundColor
Invalid characters passed for attempted conversion, these have been ignored

/dev/shm/BUILDROOT/php-zendframework-zend-barcode-2.8.0-1.fc31.remi.x86_64/usr/share/php/Zend/Barcode/Object/AbstractObject.php:463
/dev/shm/BUILD/zend-barcode-6db95687997920b8217e71d2f12b51ec10e824d9/test/Object/TestCommon.php:180


etc

In short # must be removed from $value

@michalbundyra michalbundyra added the Bug Something isn't working label Jan 2, 2020
Xerkus added a commit that referenced this pull request Jan 24, 2020
@Xerkus
Add CHANGELOG for #2
f82c1b9
@Xerkus Xerkus merged commit c765b77 into laminas:master Jan 24, 2020
Xerkus added a commit that referenced this pull request Jan 24, 2020
@Xerkus
Merge branch 'hotfix/2' into develop
ca1311c 
Forward port #2
@Xerkus Xerkus added this to the 2.8.1 milestone Jan 24, 2020
@Xerkus
Copy link
Member

Xerkus commented Jan 24, 2020

@remicollet thank you

@stasicki stasicki mentioned this pull request Dec 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Something isn't working
Projects
None yet
Milestone
2.8.1
Development

Successfully merging this pull request may close these issues.
3 participants
@remicollet @Xerkus @michalbundyra