Added warning when elements have keyword names #155
Conversation
Fixes lambda-fairy#91. To avoid erroneously preventing elements which are actually meant to be called `if` from being used, this is only a warning, with a suggestion of the template syntax.
|
I'd like to add a test for this, but I couldn't find anything on testing |
maud_macros/src/parse.rs
Outdated
| match ident_string.as_str() { | ||
| "if" | "while" | "for" | "match" | "let" => { | ||
| ident.span() | ||
| .warning(format!("found keyword `{}` - should this be a `@{}`?", ident_string, ident_string)) |
There was a problem hiding this comment.
Is it possible to use the same argument twice? Something like
format!("found keyword `{0}` - should this be a `@{0}`?", ident_string)
Yeah, we'll need to use compiletest-rs to test that properly. I think it's okay to skip the test for now. |
The formatting argument is now only passed once.
|
I had some time to get back to this, so I implemented a compiler test for the warning output. It's on a branch off this current one, if you don't want to merge it in as well. |
There was a problem hiding this comment.
Looks good to me, thanks!
I was going to wait for lint-associated warnings to land first (see rust-lang/rust#54140), so that users would have a way to silence this warning. But that probably doesn't matter. Let's push this out and see if anyone complains 😉
Great that you got compiletest working. Feel free to post another PR for that branch!
Fixes #91.
To avoid erroneously preventing elements which are actually meant to be
called
iffrom being used, this is only a warning, with a suggestionof the template syntax.