Fix csr cn generation using utf8 encoding #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes changes to improve error handling and string encoding in the certificate signing request (CSR) process and the user interface for issued certificates. The most important changes include updating the string encoding method, adding error handling for certificate signing, and enhancing the user interface to display error messages more effectively.
Improvements to string encoding and error handling:
src/utils/crypto/csr.ts: Changed the encoding ofsubjectPropsvalues fromPrintableStringtoUtf8Stringto support a wider range of characters.Enhancements to error handling and user interface:
src/views/CAs/IssuedCertificates.tsx: ImportederrorToStringutility to convert errors to user-friendly messages.src/views/CAs/IssuedCertificates.tsx: Added a try-catch block to handle errors during the certificate signing request and display appropriate error messages.src/views/CAs/IssuedCertificates.tsx: Enhanced the UI to display error messages within anAlertcomponent and provided a "Go Back" button for better user experience.addreses and fixes #40