fix csr cn generation using utf8 encoding

Signed-off-by: haritz <hsaizsierra@gmail.com>
lamassuiot · Jan 22, 2025 · 263e553 · 263e553
1 parent fdd0041
commit 263e553
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 4 deletions.
diff --git a/src/utils/crypto/csr.ts b/src/utils/crypto/csr.ts
@@ -53,7 +53,7 @@ export const createCSR = async (keyPair: CryptoKeyPair, hashAlg: "SHA-1" | "SHA-
         if (subjectProps[key]) {
             pkcs10.subject.typesAndValues.push(new pkijs.AttributeTypeAndValue({
                 type: key,
-                value: new asn1js.PrintableString({ value: subjectProps[key] })
+                value: new asn1js.Utf8String({ value: subjectProps[key] })
             }));
         }
     }

diff --git a/src/views/CAs/IssuedCertificates.tsx b/src/views/CAs/IssuedCertificates.tsx
@@ -22,6 +22,7 @@ import PublishIcon from "@mui/icons-material/Publish";
 import React, { useEffect, useState } from "react";
 import RefreshIcon from "@mui/icons-material/Refresh";
 import apicalls from "ducks/apicalls";
+import { errorToString } from "ducks/services/api-client";
 
 const queryableFields = [
     { key: "subject.common_name", title: "Common Name", operator: "contains" },
@@ -64,8 +65,12 @@ export const IssuedCertificates: React.FC<Props> = ({ caData }) => {
         component: (
             <CSRInBrowserGenerator onCreate={async (key, csr) => {
                 setImportSignStatus({ loading: true, errMessage: "", response: undefined });
-                const singResp = await apicalls.cas.signCertificateRequest(caData.id, window.window.btoa(csr));
-                setImportSignStatus({ loading: false, errMessage: "", response: singResp });
+                try {
+                    const singResp = await apicalls.cas.signCertificateRequest(caData.id, window.window.btoa(csr));
+                    setImportSignStatus({ loading: false, errMessage: "", response: singResp });
+                } catch (error: any) {
+                    setImportSignStatus({ loading: false, errMessage: errorToString(error), response: undefined });
+                }
             }} />
         )
     }, {
@@ -289,7 +294,17 @@ export const IssuedCertificates: React.FC<Props> = ({ caData }) => {
                                                     ? (
                                                         importSignStatus.errMessage !== ""
                                                             ? (
-                                                                <>{importSignStatus.errMessage}</>
+                                                                <Grid container spacing={2}>
+                                                                    <Grid xs={12}>
+                                                                        <Alert severity="error" action={
+                                                                            <Button variant="contained" color="error" size="small" onClick={() => { resetAddCertificate(); setDisplayIssueCert(false); }}>
+                                                                        Go Back
+                                                                            </Button>
+                                                                        }>
+                                                                            {importSignStatus.errMessage}
+                                                                        </Alert>
+                                                                    </Grid>
+                                                                </Grid>
                                                             )
                                                             : (
                                                                 importSignStatus.response !== undefined