Refactor lago ansible_hosts #544
Conversation
01a227f to
7ceaed3
Compare
lago/ansible.py
Outdated
|
|
||
| def get_inventory(self, keys=None): | ||
| """ | ||
| Create an Ansible inventory based on python object. |
There was a problem hiding this comment.
'Based on python object' is a bit unclear on what sort of object it expects.
lago/ansible.py
Outdated
| @@ -0,0 +1,131 @@ | |||
| from collections import defaultdict | |||
There was a problem hiding this comment.
The filename ansible.py might be problematic if we ever try in the future to use ansible's own API(i.e. import ansible), also for users of Lago(i.e. they might do from lago import ansible)
Similarly to how running ipython on my env inside lago/lago directory fails because it conflicts with cmd.py :/
lago/ansible.py
Outdated
| """ | ||
| inventory = defaultdict(list) | ||
| keys = keys or ['vm-type', 'groups', 'vm-provider'] | ||
| vms = self.virt.get_vms().values() |
There was a problem hiding this comment.
I think you can call this directly from the prefix no?
i.e.
self.prefix.get_vms().values()|
|
||
| The 'keys' parameter can be used to override the default groups, | ||
| for example to create a group which based on a 'service_provider', | ||
| --keys 'service_provider' should be added to this command. |
lago/cmd.py
Outdated
| for every item in that list (this is useful when you want to associate | ||
| a machine with more than one group). | ||
|
|
||
| The output of this command ansis printed to standard output. |
| help='Path to the keys that should be used as groups', | ||
| default=['vm-type', 'groups', 'vm-provider'], | ||
| metavar='KEY', | ||
| nargs='*', |
There was a problem hiding this comment.
Just making sure - this change is compatible with the old API?(i.e. what OST Ansible uses).
There was a problem hiding this comment.
It's not.
Currently OST Ansible uses [ovirt-host], [ovirt-engine] while the new names
are [vm-type=ovirt-host], [vm-type=ovirt-engine].
Since any key can be used as a group, I have to keep it this way (in order to create a unique group name).
| return self._spec['vm-type'] | ||
|
|
||
| @property | ||
| def groups(self): |
7ceaed3 to
4806d99
Compare
1. Every key in the init file can be used as a group. In order to create a unique name for each group, the value is prefixed with the series of keys and indexes that points to it (for example [vm-type=ovirt-host]). 2. Added the option to specify 'groups' key in the domain definition, this key should point to a list of groups that the domain belongs to. 3. Moved the logic to a new file called ansible.py (this way 'lago sdk' would be able to use it without the need for cmd.py). Signed-off-by: gbenhaim <galbh2@gmail.com>
4806d99 to
b3a0bcc
Compare
|
ci merge please |
Every key in the init file can be used as a group.
In order to create a unique name for each group, the
value is prefixed with the series of keys and indexes that
points to it (for example [vm-type=ovirt-host]).
Added the option to specify 'groups' key in the domain definition,
this key should point to a list of groups that the domain belongs to.
Moved the logic to a new file called ansible.py (this way 'lago sdk'
would be able to use it without the need for cmd.py).
For more info check out the description in cmd.py
closes #429
Signed-off-by: gbenhaim galbh2@gmail.com