ovirtlago: change --with-vms timeout in 'lago ovirt start' to 8 minutes #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbenhaim
reviewed
Apr 24, 2017
ovirtlago/cmd.py
Outdated
| with LogTask('Starting oVirt environment'): | ||
| prefix.start() | ||
| with LogTask('Waiting for ovirt-engine status'): | ||
| prefix.virt_env.assert_engine_alive() | ||
| prefix.virt_env.assert_engine_alive(timeout=2 * 60) |
There was a problem hiding this comment.
I'm afraid that we will hit this timeout also, what do you think ?
There was a problem hiding this comment.
Could be - this would mean it takes libvirt to boot the VM and until the engine service is running more than 2 minutes, which seems a lot. I never had it timed out on that stage, though I never had it timed out on the 'vms' start either. I actually think that the timeout for the VMs now is huge - 8 minutes. But practically I can't think of any other 'hot fix' for that..
You experienced it timing out on this engine service stage?
There was a problem hiding this comment.
Updated to 3 minutes.
fc89c24 to
74f75d8
Compare
1. Increased default timeout for waiting until the VMs connected to the Engine report 'up' status to 8 minutes. 2. Added '--vms-timeout' parameter to allow configuring that timeout. 3. Increased 'ovirt-engine'/'vdsmd' service timeout to 3 minutes. 4. Added default timeouts in all relevant functions headers, and set the timeouts explicitly in 'do_ovirt_start' for visibility. Signed-off-by: Nadav Goldin <ngoldin@redhat.com>
74f75d8 to
33ca8c0
Compare
|
ci merge please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ovirtlago: reconfigure timeouts in 'lago ovirt start'
to the Engine report 'up' status to 8 minutes.
the timeouts explicitly in 'do_ovirt_start' for visibility.