Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gradients canny cht #1249

Merged
merged 16 commits into from
Oct 27, 2023
Merged

Conversation

rolalaro
Copy link

@rolalaro rolalaro commented Oct 9, 2023

  • Choice between the OpenCV and ViSP backend for the Canny computation
  • Computation of the gradient using Gaussian blur + Sobel instead of derivativeGaussianFillter
  • New method of Canny auto threshold

rlagneau added 5 commits October 6, 2023 14:16
… terms of image type and filter type. Adapted calls to these methods in some classes. [WIP] Added a first draft of Canny auto-threshold [CORPS] Changed the way the gradients are computed in vpCannyEdgeDetection and vpCircleHoughTransform classes
…g + gradient operator (only Gaussian blur + Sobel at the moment) and upper threshold ratio + lower threshold ratio are now parameters
@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Attention: 375 lines in your changes are missing coverage. Please review.

Comparison is base (fe4e89c) 54.75% compared to head (2512b21) 54.37%.
Report is 16 commits behind head on master.

❗ Current head 2512b21 differs from pull request most recent head ae3f1ad. Consider uploading reports for the commit ae3f1ad to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1249      +/-   ##
==========================================
- Coverage   54.75%   54.37%   -0.38%     
==========================================
  Files         403      403              
  Lines       50261    50507     +246     
==========================================
- Hits        27519    27464      -55     
- Misses      22742    23043     +301     
Files Coverage Δ
modules/core/include/visp3/core/vpHistogram.h 25.00% <ø> (ø)
modules/core/include/visp3/core/vpImageConvert.h 93.33% <ø> (ø)
modules/imgproc/src/vpImgproc.cpp 92.85% <100.00%> (-0.38%) ⬇️
modules/core/src/tools/histogram/vpHistogram.cpp 78.66% <93.33%> (+0.73%) ⬆️
...les/core/include/visp3/core/vpCannyEdgeDetection.h 0.00% <0.00%> (ø)
modules/core/src/image/vpImageConvert.cpp 18.47% <0.00%> (-0.19%) ⬇️
...roc/include/visp3/imgproc/vpCircleHoughTransform.h 0.00% <0.00%> (ø)
modules/imgproc/src/vpCircleHoughTransform.cpp 0.00% <0.00%> (ø)
modules/core/src/image/vpCannyEdgeDetection.cpp 0.00% <0.00%> (ø)
modules/core/include/visp3/core/vpImageFilter.h 68.92% <26.08%> (-23.51%) ⬇️
... and 1 more

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rolalaro rolalaro force-pushed the fixGradientsCannyCHT branch from 3692eb4 to 6687512 Compare October 18, 2023 08:34
rlagneau added 3 commits October 18, 2023 10:43
…s, with which the computeCannyThreshold method works better.
…le + normalize OpenCV gradients to make the computeCannyThresh works
@rolalaro
Copy link
Author

rolalaro commented Oct 18, 2023

Remaining work:

  • Add a tutorial for Canny
  • Add a method to compute the partial normalized gradients
  • If auto keyword is not allowed, change the scaleFilter lambda into a method in vpImageFilter (?)

rlagneau added 2 commits October 18, 2023 17:40
@rolalaro rolalaro changed the title [DRAFT] Fix gradients canny cht Fix gradients canny cht Oct 19, 2023
@fspindle fspindle merged commit af97521 into lagadic:master Oct 27, 2023
56 checks passed
@rolalaro rolalaro deleted the fixGradientsCannyCHT branch October 27, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants