-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gradients canny cht #1249
Fix gradients canny cht #1249
Conversation
rolalaro
commented
Oct 9, 2023
- Choice between the OpenCV and ViSP backend for the Canny computation
- Computation of the gradient using Gaussian blur + Sobel instead of derivativeGaussianFillter
- New method of Canny auto threshold
… terms of image type and filter type. Adapted calls to these methods in some classes. [WIP] Added a first draft of Canny auto-threshold [CORPS] Changed the way the gradients are computed in vpCannyEdgeDetection and vpCircleHoughTransform classes
…g + gradient operator (only Gaussian blur + Sobel at the moment) and upper threshold ratio + lower threshold ratio are now parameters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1249 +/- ##
==========================================
- Coverage 54.75% 54.37% -0.38%
==========================================
Files 403 403
Lines 50261 50507 +246
==========================================
- Hits 27519 27464 -55
- Misses 22742 23043 +301
☔ View full report in Codecov by Sentry. |
…histogram version of the gradient with OpenCV
3692eb4
to
6687512
Compare
…s, with which the computeCannyThreshold method works better.
…le + normalize OpenCV gradients to make the computeCannyThresh works
Remaining work:
|
… depending on the vpCannyFilteringAndGradientType and vpCannyBackendType
…ering types for Canny
…radient to find the peak