Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add redix-indexer feature #3

Merged
merged 4 commits into from
Apr 19, 2017
Merged

add redix-indexer feature #3

merged 4 commits into from
Apr 19, 2017

Conversation

harunalfat
Copy link
Member

Feature related to #1

Copy link
Member

@abrari abrari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kalau misalnya value-nya bukan string gimana? (Saya gak tau di redis apakah bisa value tipenya kompleks)

Kan itu sebenernya array tapi dijadiin string separated by ";". Jadi pas retrieve nanti gak perlu di-parsing lagi manual.

Eh atau disimpen bentuk serialized / json_encoded?

@harunalfat
Copy link
Member Author

Bisa sih kak Abrar, tadi sempat kepikiran untuk pakai set di redis.

Jadi dalam key per trigram isinya array per id fonetik dengan isinya frekuensi muncul dan posisi itu.

key['vocal-BBB'][$fonetik_id] 

@harunalfat
Copy link
Member Author

Interesting, dengan menggunakan mode verbose dan cache dimatikan, saya coba cek dengan query shoffati wa yaqbid :

file_based_index : stabil di 0.068-0.071 detik
redis_string (pakai ';') : stabil di 0.07 detik
redis_hash (pakai json encoded) : stabil di 0.11 detik

yang hash pakai

key['vocal-BBB'][$fonetik_id] = "{'freq': 2, 'pos': [68,79]}";

apa yang perlu di-tuning yah? 🤔

@harunalfat
Copy link
Member Author

harunalfat commented Apr 11, 2017

Ah, kayaknya si redis hash emang lambat. Meskipun saya pakai

key['vocal-BBB']['751'] = "[2,[250,266]]"; -> 1 detik

Kalau saya pakai

key['vocal-BBB'] = "[['262',1,[245]],['751',2,[250,266]]]";

dia stabil di 0.068 detik. Tapi ga jauh ya peningkatannya? 😅

@harunalfat
Copy link
Member Author

sudah diupdate dengan index disimpan sebagai

key['vocal-BBB'] = "[['262',1,[245]],['751',2,[250,266]]]";

mohon dicek 😄

@abrari
Copy link
Member

abrari commented Apr 11, 2017

Okay mungkin nanti perlu profiling juga biar ketahuan proses mana yang bikin lama.

Summon @ariefsam juga buat lihat PR ini 😁

@abrari abrari merged commit 2ca5536 into master Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants