Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(azure): configure flexible subscription ids #74

Merged
merged 1 commit into from
Sep 25, 2020
Merged

Conversation

afiune
Copy link
Contributor

@afiune afiune commented Sep 10, 2020

We have introduced the following behavior when choosing which
subscriptions to grant read access to:

  • By default, we grant access to only the primary subscription
  • If the user prefers to, they can provide a list of subscriptions to grant read access to
  • Finally, users can also opt to grant read access to ALL subscriptions within a tenant

New inputs:

Name Description Type Default Required
subscription_ids A list of subscriptions to grant read access to, by default the modules will only use the primary subscription list(string) [] no
all_subscriptions If set to true, grant read access to ALL subscriptions within the selected Tenant (overrides subscription_ids) bool false no

Signed-off-by: Salim Afiune Maya afiune@lacework.net

Copy link
Contributor

@andrewwoj andrewwoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We have introduced the following behavior when choosing which
subscriptions to grant read access to:

* By default, we grant access to only the primary subscription
* If the user prefers to, they can provide a list of subscriptions to grant read access to
* Finally, users can also opt to grant read access to ALL subscriptions within a tenant

New inputs:

| Name | Description | Type | Default | Required |
|------|-------------|------|---------|:--------:|
| subscription_ids | A list of subscriptions to grant read access to, by default the modules will only use the primary subscription | `list(string)` | `[]` | no |
| all_subscriptions | If set to true, grant read access to ALL subscriptions within the selected Tenant (overrides `subscription_ids`) | `bool` | false | no |

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@afiune afiune changed the title feat(azure): more flexible subscription ids feat(azure): configure flexible subscription ids Sep 24, 2020
Copy link
Contributor

@scottford-lw scottford-lw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@afiune afiune merged commit 4b3e99b into master Sep 25, 2020
@afiune afiune mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants