Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(gcp): fix TF_VAR prefix in README.md #28

Merged
merged 2 commits into from
Jun 3, 2020
Merged

docs(gcp): fix TF_VAR prefix in README.md #28

merged 2 commits into from
Jun 3, 2020

Conversation

afiune
Copy link
Contributor

@afiune afiune commented Jun 3, 2020

Terraform documentation says that the prefix is TF_VAR instead of TF_VARS,
this change updates the README.md to use such prefixes:

https://www.terraform.io/docs/commands/environment-variables.html#tf_var_name

Additionally, added a nitpick change to remove empty lines from gcp/variables.tf

tenor-232668769

afiune added 2 commits June 3, 2020 16:14
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
@afiune afiune added the documentation Improvements or additions to documentation label Jun 3, 2020
@afiune afiune requested review from andrewwoj and scottford-lw June 3, 2020 22:16
@afiune afiune self-assigned this Jun 3, 2020
Copy link
Contributor

@scottford-lw scottford-lw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 good catch @afiune

@afiune afiune merged commit 44aad17 into master Jun 3, 2020
@afiune afiune deleted the afiune/docs branch July 29, 2020 13:19
@afiune afiune mentioned this pull request Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants