Rework timeout middleware to use http.TimeoutHandler implementation. …

[aldas]

Fix #1761 - Reworked timeout middleware to use http.TimeoutHandler implementation.

NB: Replaced ErrorHandler with ErrorMessage and OnTimeoutRouteErrorHandler on config struct (fix #1761) - this is breaking change but for http.TimeoutHandler there is no special case for timeout errors - that handler will take care of it itself.

[codecov]

Codecov Report

Merging #1801 (736820f) into master (6f9b71c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1801   +/-   ##
=======================================
  Coverage   89.56%   89.57%           
=======================================
  Files          32       32           
  Lines        2646     2648    +2     
=======================================
+ Hits         2370     2372    +2     
  Misses        178      178           
  Partials       98       98           

Impacted Files	Coverage Δ
middleware/timeout.go	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f9b71c...736820f. Read the comment docs.

[lammel]

This is quite some interesting code to review @aldas ;-)

As we just introduced the timeout Middleware with v4.2.0 I think a breaking change is acceptable due to a functional issue (datarace). So I'm in favor of merging this for v4.2.1

[lammel]

No datarace found during testing of tests.
Looks good to me.

[joewhite86]

@lammel @aldas why was the ErrorHandler removed?
I want to use a custom error handler, that returns json instead of HTML. How can I achieve this now?