fix README.md #194
Merged
fix README.md #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OHHHHH.... THX! |
la10736
pushed a commit
that referenced
this pull request
Apr 30, 2023
(cherry picked from commit 4378e0e)
la10736
added a commit
that referenced
this pull request
Jun 7, 2023
* Moved extract files in RsTestData * Base implementation without test * MVP completed and test example in playground * Make values creation more testable * Revert "Implemented arguments's files parsing" This reverts commit 6a197fd. * Update rstest requirement from 0.16.0 to 0.17.0 (#192) Updates the requirements on [rstest](https://github.com/la10736/rstest) to permit the latest version. - [Release notes](https://github.com/la10736/rstest/releases) - [Changelog](https://github.com/la10736/rstest/blob/master/CHANGELOG.md) - [Commits](0.16.0...0.17.0) --- updated-dependencies: - dependency-name: rstest dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix #189 * Call visit_item_fn_mut in a custom visit_item_fn_mut can cause wired behavior because it will also visit inner functions. A clean solution to #189 is to take the responsibility of the two extraction separated. Also we removed the inner visit_item_fn_mut for all others extractions because are useless and can cause also wired bugs * Update changelog * Prepare new version * Make values creation more testable * Missed mod files in rebase * Fix imports * Refactor for testing * Coverage all errors * Introduce exclude parsing * Implemented filter * fix README.md (#194) (cherry picked from commit 4378e0e) * Fixed tests for last rust version * Use relative path to make regex cross platform * Introduce logic to accept or reject dot files * Implement sort and multiple glob (missed parsing) * Implemented support for more exclude * Implement parsing new syntax (include_dot_files and multiple files and exclude attributes). Tests about new syntax and error. Missed: - error should point attributes and not arguments - Docs - Refactoring (clean code) - Test E2E - Change log * Now error point to attributes * Refactor * Refactor * Add licenses (#196) Symlink license files from the parent directory so that crates are created with them. Needed for distribution especially for the MIT license. Signed-off-by: Michel Alexandre Salim <salimma@fedoraproject.org> * Fixed docs: example in wrong section * Docs * Changelog * E2E test * Move tests on sanitize_ident near to implementation --------- Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Michel Alexandre Salim <salimma@fedoraproject.org> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: kenkoooo <kenkou.n@gmail.com> Co-authored-by: Michel Alexandre Salim <michel@michel-slm.name>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I got stuck with the example on the README, and I finally realized that it was a bit incorrect.