This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Make the array syntax consistent #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all other places we use `.{index}` syntax to flatten array elements.
Having a single place where we do `[{index}]` messes up the meta.json
description generation. See the Discord message described in the linked
Linear issue to see an example.
|
adamiak
approved these changes
Mar 12, 2024
adamiak
pushed a commit
to l2beat/l2beat
that referenced
this pull request
Apr 24, 2024
* Make the array syntax consistent
In all other places we use `.{index}` syntax to flatten array elements.
Having a single place where we do `[{index}]` messes up the meta.json
description generation. See the Discord message described in the linked
Linear issue to see an example.
* Changeset
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves L2B-4365
Description
In all other places we use
.{index}syntax to flatten array elements.Having a single place where we do
[{index}]messes up the meta.jsondescription generation. See the Discord message described in the linked
Linear issue to see an example.