Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible bug: mockFn().reset() should also reset calls #290

Closed
dhardtke opened this issue Jul 16, 2023 · 0 comments · Fixed by #291
Closed

Possible bug: mockFn().reset() should also reset calls #290

dhardtke opened this issue Jul 16, 2023 · 0 comments · Fixed by #291

Comments

@dhardtke
Copy link
Contributor

I would expect reset() to reset a mock's calls as well. Otherwise, I would have to manually empty the calls array before each test.
dhardtke added a commit to dhardtke/earl that referenced this issue Jul 16, 2023
@dhardtke
fix(mocks): reset should empty calls
4383069 
Fixes l2beat#290
@dhardtke dhardtke mentioned this issue Jul 16, 2023
Merged
sz-piotr added a commit that referenced this issue Apr 21, 2024
@dhardtke @sz-piotr
Add .clear method to mocks. Fix .reset (#291)
46f000c 
* fix(mocks): reset should empty calls

Fixes #290

* Add .clear method to mocks

* Add changeset

---------

Co-authored-by: Piotr Szlachciak <szlachciak.piotr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mocks): reset should empty calls dhardtke/earl
1 participant
@dhardtke