Start migration to biome linter

examples/example-plugin/src/toBeEven.ts

@@ -1,7 +1,6 @@
-import { Control, formatCompact, registerValidator } from 'earl'
+import { type Control, formatCompact, registerValidator } from 'earl'
 
 declare module 'earl' {
-  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   interface Validators<T> {
     toBeEven(this: Validators<number>): void
   }

packages/e2e/test-esbuild/stack-traces.test.ts

@@ -28,7 +28,7 @@ async function captureErrorAsync(fn: () => Promise<void>) {
 
 function getStack(error: Error) {
   const stack = utils.stackTraceFilter()(error.stack ?? '')
-  return Parser.parse({ stack } as any).map((x) => ({
+  return Parser.parse({ stack } as Error).map((x) => ({
     at: x.functionName,
     file: x.fileName,
   }))

packages/e2e/test-ts-node/stack-traces.test.ts

@@ -28,7 +28,7 @@ async function captureErrorAsync(fn: () => Promise<void>) {
 
 function getStack(error: Error) {
   const stack = utils.stackTraceFilter()(error.stack ?? '')
-  return Parser.parse({ stack } as any).map((x) => ({
+  return Parser.parse({ stack } as Error).map((x) => ({
     at: x.functionName,
     file: x.fileName,
   }))

packages/earl/src/expect.ts

@@ -2,11 +2,10 @@ import { Control } from './Control.js'
 import { formatCompact } from './format/index.js'
 
 // to be overridden by plugins
-// eslint-disable-next-line @typescript-eslint/no-unused-vars
-export interface Validators<T> {}
+export type Validators<T> = {}
 
 // to be overridden by plugins
-export interface Matchers {}
+export type Matchers = {}
 
 export class Matcher {
   constructor(

packages/earl/src/format/FormatOptions.ts

@@ -31,7 +31,7 @@ export const DEFAULT_FORMAT_OPTIONS: FormatOptions = {
   ...DEFAULT_EQUALITY_OPTIONS,
   indentSize: 2,
   inline: false,
-  maxLineLength: Infinity,
+  maxLineLength: Number.POSITIVE_INFINITY,
   skipMatcherReplacement: false,
   requireStrictEquality: false,
 }

packages/earl/src/format/format.test.ts

@@ -14,7 +14,7 @@ describe('format', () => {
     compareErrorStack: false,
     indentSize: 2,
     inline: false,
-    maxLineLength: Infinity,
+    maxLineLength: Number.POSITIVE_INFINITY,
     skipMatcherReplacement: false,
     requireStrictEquality: false,
   }
@@ -33,11 +33,11 @@ describe('format', () => {
         [0.2, null, '0.2'],
         [-3, null, '-3'],
         [1e50, null, '1e+50'],
-        [NaN, null, 'NaN'],
-        [NaN, NaN, 'NaN'],
-        [NaN, NaN, 'NaN (different)', { uniqueNaNs: true }],
-        [Infinity, null, 'Infinity'],
-        [-Infinity, null, '-Infinity'],
+        [Number.NaN, null, 'NaN'],
+        [Number.NaN, Number.NaN, 'NaN'],
+        [Number.NaN, Number.NaN, 'NaN (different)', { uniqueNaNs: true }],
+        [Number.POSITIVE_INFINITY, null, 'Infinity'],
+        [Number.NEGATIVE_INFINITY, null, '-Infinity'],
         [0, null, '0'],
         [-0, null, '0'],
         [-0, null, '-0', { minusZero: true }],
@@ -85,8 +85,8 @@ describe('format', () => {
       testCases: [
         [function a() {}, null, 'function a()'],
         [function a() {}, function a() {}, 'function a() (different)'],
-        [function () {}, null, 'function [anonymous]()'],
-        [function () {}, function () {}, 'function [anonymous]() (different)'],
+        [() => {}, null, 'function [anonymous]()'],
+        [() => {}, () => {}, 'function [anonymous]() (different)'],
         [function* foo() {}, null, 'function* foo()'],
         [function* foo() {}, function* foo() {}, 'function* foo() (different)'],
         [function* () {}, null, 'function* [anonymous]()'],
@@ -97,7 +97,6 @@ describe('format', () => {
         ],
         // This is eval-ed to avoid typescript transpiling it
         // With a higher target this wouldn't be necessary
-        // eslint-disable-next-line no-eval
         ...eval(`[
           [async function foo() {}, null, 'async function foo()'],
           [async function foo() {}, async function foo() {}, 'async function foo() (different)'],
@@ -126,7 +125,7 @@ describe('format', () => {
           'function x() (different) & {\n  a: 1\n}',
         ],
         [
-          Object.assign(function () {}, { a: 1 }),
+          Object.assign(() => {}, { a: 1 }),
           null,
           'function [anonymous]() & {\n  a: 1\n}',
         ],

packages/earl/src/format/formatCompact.test.ts

@@ -13,9 +13,9 @@ describe('formatCompact', () => {
     [0.2, '0.2'],
     [-3, '-3'],
     [1e50, '1e+50'],
-    [NaN, 'NaN'],
-    [Infinity, 'Infinity'],
-    [-Infinity, '-Infinity'],
+    [Number.NaN, 'NaN'],
+    [Number.POSITIVE_INFINITY, 'Infinity'],
+    [Number.NEGATIVE_INFINITY, '-Infinity'],
     [BigInt(1), '1n'],
     [BigInt(123), '123n'],
     [BigInt(-123), '-123n'],
@@ -33,7 +33,7 @@ describe('formatCompact', () => {
     [undefined, 'undefined'],
     [true, 'true'],
     [false, 'false'],
-    [function () {}, 'function [anonymous]()'],
+    [() => {}, 'function [anonymous]()'],
     [function foo() {}, 'function foo()'],
     [class Foo {}, 'class Foo'],
     [class {}, 'class [anonymous]'],

packages/earl/src/format/formatNumber.ts

@@ -8,8 +8,8 @@ export function formatNumber(
 ) {
   if (Object.is(value, -0) && options.minusZero) {
     return toLine('-0')
-  } else if (Object.is(value, NaN)) {
-    if (options.uniqueNaNs && Object.is(sibling, NaN)) {
+  } else if (Object.is(value, Number.NaN)) {
+    if (options.uniqueNaNs && Object.is(sibling, Number.NaN)) {
       return toLine('NaN (different)')
     }
     return toLine('NaN')

packages/earl/src/format/formatUnknown.ts

@@ -87,7 +87,7 @@ export function formatUnknown(
   if (
     type === 'Error' &&
     options.inline &&
-    options.maxLineLength !== Infinity
+    options.maxLineLength !== Number.POSITIVE_INFINITY
   ) {
     return toLine(
       `${typeName ?? ''}(${formatString((value as Error).message, options)})`,

packages/earl/src/format/getComparedTypeName.ts

@@ -57,14 +57,12 @@ function getPrototypeName(value: object) {
   return '[custom prototype]'
 }
 
-// eslint-disable-next-line @typescript-eslint/ban-types
 export function getFunctionTypeName(value: Function) {
   const type = getFunctionType(value)
   const name = value.name || '[anonymous]'
   return `${type} ${name}${type === 'class' ? '' : '()'}`
 }
 
-// eslint-disable-next-line @typescript-eslint/ban-types
 function getFunctionType(value: Function) {
   if (value.toString().startsWith('class')) {
     return 'class'

packages/earl/src/isEqual/isEqual.perf.test.ts

@@ -29,7 +29,7 @@ describe('isEqual performance', function () {
     roles: ['User', 'Admin'],
   }
 
-  it('measure', function () {
+  it('measure', () => {
     const repeat = 5
     const iterations = 2000
     const testValue = [dataObject, dataObject, dataObject]

packages/earl/src/isEqual/isEqual.test.ts

@@ -20,7 +20,7 @@ describe('isEqual', () => {
     minusZero: true,
     indentSize: 2,
     inline: true,
-    maxLineLength: Infinity,
+    maxLineLength: Number.POSITIVE_INFINITY,
     skipMatcherReplacement: true,
     requireStrictEquality: false,
   }
@@ -52,11 +52,11 @@ describe('isEqual', () => {
         [123.456, -123.456, false],
         [0, -0, true],
         [0, -0, false, { minusZero: true }],
-        [NaN, NaN, true],
-        [NaN, NaN, false, { uniqueNaNs: true }],
-        [Infinity, Infinity, true],
-        [Infinity, -Infinity, false],
-        [-Infinity, -Infinity, true],
+        [Number.NaN, Number.NaN, true],
+        [Number.NaN, Number.NaN, false, { uniqueNaNs: true }],
+        [Number.POSITIVE_INFINITY, Number.POSITIVE_INFINITY, true],
+        [Number.POSITIVE_INFINITY, Number.NEGATIVE_INFINITY, false],
+        [Number.NEGATIVE_INFINITY, Number.NEGATIVE_INFINITY, true],
       ],
     },
     {
@@ -119,9 +119,9 @@ describe('isEqual', () => {
             function* named() {},
             async function named() {},
             async function* named() {},
-            function () {},
+            () => {},
             function* () {},
-            async function () {},
+            async () => {},
             async function* () {},
           ]
           const testCases: TestCase[] = []
@@ -330,13 +330,8 @@ describe('isEqual', () => {
         ...(() => {
           class MyRegExp extends RegExp {}
           return [
-            [new RegExp('foo'), new MyRegExp('foo'), false],
-            [
-              new RegExp('foo'),
-              new MyRegExp('foo'),
-              true,
-              { ignorePrototypes: true },
-            ],
+            [/foo/, new MyRegExp('foo'), false],
+            [/foo/, new MyRegExp('foo'), true, { ignorePrototypes: true }],
             [new MyRegExp('foo'), new MyRegExp('foo'), true],
             [new MyRegExp('foo'), new MyRegExp('bar'), false],
             [
@@ -651,7 +646,7 @@ describe('isEqual', () => {
             ...equalityOptions,
             indentSize: 2,
             inline: false,
-            maxLineLength: Infinity,
+            maxLineLength: Number.POSITIVE_INFINITY,
             skipMatcherReplacement: false,
             requireStrictEquality: false,
           }

packages/earl/src/isEqual/isEqualNumber.ts

@@ -5,8 +5,8 @@ export function isEqualNumber(
   other: number,
   options: EqualityOptions,
 ) {
-  if (isNaN(value)) {
-    return options.uniqueNaNs ? false : isNaN(other)
+  if (Number.isNaN(value)) {
+    return options.uniqueNaNs ? false : Number.isNaN(other)
   } else if (value === 0) {
     return options.minusZero ? Object.is(value, other) : other === 0
   } else {

packages/earl/src/isEqual/isEqualObject.ts

@@ -27,10 +27,10 @@ export function isEqualObject(
   for (let i = 0; i < keys.length; i++) {
     if (
       !isEqualUnknown(
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+        // biome-ignore lint/style/noNonNullAssertion: We know that the key exists
         (value as any)[keys[i]!],
         valueStack,
-        // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+        // biome-ignore lint/style/noNonNullAssertion: We know that the key exists
         (other as any)[otherKeys[i]!],
         otherStack,
         options,

packages/earl/src/matchers/basic/a.test.ts

@@ -24,8 +24,10 @@ describe(a.name, () => {
 
     testMatcher(
       a(Number),
-      TEST_VALUES.filter((x) => typeof x === 'number' && !Number.isNaN(x)),
-      TEST_VALUES.filter((x) => typeof x !== 'number').concat(NaN),
+      TEST_VALUES.filter(
+        (x) => typeof x === 'number' && !Number.Number.isNaN(x),
+      ),
+      TEST_VALUES.filter((x) => typeof x !== 'number').concat(Number.NaN),
     )
   })
 

packages/earl/src/matchers/basic/a.ts

@@ -47,7 +47,7 @@ export function a(type: NewableOrPrimitive) {
     if (type === String) {
       return typeof value === 'string'
     } else if (type === Number) {
-      return typeof value === 'number' && !isNaN(value)
+      return typeof value === 'number' && !Number.isNaN(value)
     } else if (type === Boolean) {
       return typeof value === 'boolean'
     } else if (type === BigInt) {

packages/earl/src/matchers/numbers/between.test.ts

@@ -19,7 +19,7 @@ describe(between.name, () => {
         -Number.EPSILON,
         Number.NEGATIVE_INFINITY,
         Number.POSITIVE_INFINITY,
-        NaN,
+        Number.NaN,
         ...TEST_VALUES.filter(
           (x) => typeof x !== 'number' && typeof x !== 'bigint',
         ),

packages/earl/src/matchers/numbers/closeTo.test.ts

@@ -15,7 +15,7 @@ describe(closeTo.name, () => {
       5,
       123,
       -4,
-      NaN,
+      Number.NaN,
       ...TEST_VALUES.filter((x) => typeof x !== 'number'),
     ],
   )

packages/earl/src/matchers/numbers/greaterThan.test.ts

@@ -9,7 +9,15 @@ describe(greaterThan.name, () => {
   describe('greaterThan(10)', () => {
     testMatcher(
       greaterThan(10),
-      [11, 10.5, 100, 12356.789, Infinity, BigInt(11), BigInt(100)],
+      [
+        11,
+        10.5,
+        100,
+        12356.789,
+        Number.POSITIVE_INFINITY,
+        BigInt(11),
+        BigInt(100),
+      ],
       [
         10,
         0,
@@ -19,8 +27,8 @@ describe(greaterThan.name, () => {
         9.998,
         5,
         -4,
-        NaN,
-        -Infinity,
+        Number.NaN,
+        Number.NEGATIVE_INFINITY,
         BigInt(10),
         BigInt(0),
         BigInt(-100),

packages/earl/src/matchers/numbers/greaterThanOrEqual.test.ts

@@ -15,7 +15,7 @@ describe(greaterThanOrEqual.name, () => {
         10.5,
         100,
         12356.789,
-        Infinity,
+        Number.POSITIVE_INFINITY,
         BigInt(10),
         BigInt(11),
         BigInt(100),
@@ -28,8 +28,8 @@ describe(greaterThanOrEqual.name, () => {
         9.998,
         5,
         -4,
-        NaN,
-        -Infinity,
+        Number.NaN,
+        Number.NEGATIVE_INFINITY,
         BigInt(0),
         BigInt(-100),
         ...TEST_VALUES.filter(

packages/earl/src/matchers/numbers/integer.test.ts

@@ -24,9 +24,9 @@ describe(integer.name, () => {
     [
       0.5,
       -1.2,
-      Infinity,
-      -Infinity,
-      NaN,
+      Number.POSITIVE_INFINITY,
+      Number.NEGATIVE_INFINITY,
+      Number.NaN,
       TEST_VALUES.filter((x) => typeof x !== 'number' && typeof x !== 'bigint'),
     ],
   )

packages/earl/src/matchers/numbers/lessThan.test.ts

@@ -17,7 +17,7 @@ describe(lessThan.name, () => {
         -1,
         -100,
         -12356.789,
-        -Infinity,
+        Number.NEGATIVE_INFINITY,
         BigInt(9),
         BigInt(0),
         BigInt(-100),
@@ -26,8 +26,8 @@ describe(lessThan.name, () => {
         10,
         11,
         19.998,
-        NaN,
-        Infinity,
+        Number.NaN,
+        Number.POSITIVE_INFINITY,
         BigInt(10),
         BigInt(100),
         ...TEST_VALUES.filter(

packages/earl/src/matchers/numbers/lessThanOrEqual.test.ts

@@ -18,7 +18,7 @@ describe(lessThanOrEqual.name, () => {
         -1,
         -100,
         -12356.789,
-        -Infinity,
+        Number.NEGATIVE_INFINITY,
         BigInt(10),
         BigInt(9),
         BigInt(0),
@@ -27,8 +27,8 @@ describe(lessThanOrEqual.name, () => {
       [
         11,
         19.998,
-        NaN,
-        Infinity,
+        Number.NaN,
+        Number.POSITIVE_INFINITY,
         BigInt(100),
         ...TEST_VALUES.filter(
           (x) => typeof x !== 'number' && typeof x !== 'bigint',