Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change checkout to sha #473

Closed
wants to merge 1 commit into from
Closed

Conversation

VOID404
Copy link
Contributor

@VOID404 VOID404 commented Oct 31, 2024

Description

Changes proposed in this pull request:

Here checkout uses head sha instead of head ref when checking out code.
I am not sure if this is an improvement...
This might let us remove line 48 and this might fix issues with force pushing different code to the same branch (which right now seems to break checkout).

This method is also mentioned in checkout action's issue with checking out in pull_request_target: link.

Related issue(s)

@VOID404 VOID404 requested a review from a team as a code owner October 31, 2024 06:51
@kyma-bot kyma-bot added area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 31, 2024
@VOID404
Copy link
Contributor Author

VOID404 commented Oct 31, 2024

I couldn't find the content of those variables described, the docs just list what vars there are, not what they contain

@VOID404
Copy link
Contributor Author

VOID404 commented Oct 31, 2024

Here is the Neighbors™ solution for this problem, we should probably do that instead.

@VOID404 VOID404 closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants