Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify code-check for better readability #175

Merged
merged 1 commit into from
Mar 16, 2024
Merged

Simplify code-check for better readability #175

merged 1 commit into from
Mar 16, 2024

Conversation

kyaukyuai
Copy link
Owner

@kyaukyuai kyaukyuai commented Mar 16, 2024

Summary by CodeRabbit

  • Refactor: Makefileのcode-checkターゲットからblack-checkターゲットを削除しました。これにより、Pythonのコードフォーマットチェックが行われなくなります。この変更は、開発者の作業フローに影響を与え、コードの品質保証プロセスに変更をもたらします。

@kyaukyuai kyaukyuai self-assigned this Mar 16, 2024
@github-actions github-actions bot added the bug Something isn't working label Mar 16, 2024
Copy link
Contributor

sweep-ai bot commented Mar 16, 2024

Apply Sweep Rules to your PR?

  • Apply: All new business logic should have corresponding unit tests.
  • Apply: Refactor large functions to be more modular.
  • Apply: Add docstrings to all functions and file headers.

This is an automated message generated by Sweep AI.

Copy link

github-actions bot commented Mar 16, 2024

Image description CodeRabbit

Walkthrough

この変更では、Makefileのcode-checkターゲットからblack-checkターゲットが削除され、PythonのコードフォーマッターであるBlackを使用したコードのフォーマットチェックが行われなくなります。

Changes

ファイル 変更の概要
Makefile code-checkターゲットからblack-checkターゲットを削除。これにより、Blackを使用したコードのフォーマットチェックが行われなくなる。

🐇

変更は風のように、

静かに、しかし確実に進む。

コードは流れ、フォーマットは変わる、

しかし、私たちの目的は常に一緒だ。

🎉🎉🎉


Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 069c0c1 and 277ffe4 commits.
Files selected (1)
  • Makefile (1)
Review comments generated (1)
  • Review: 1
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

Comment on lines 22 to +25
pre-commit-run:
poetry run pre-commit run --all-files

code-check: flake8-check black-check pre-commit-run
code-check: flake8-check pre-commit-run

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

black-checkターゲットの削除により、Blackを使用したコードのフォーマットチェックが行われなくなりました。これは意図した変更である場合、問題ありません。ただし、Pythonのコードフォーマットの一貫性を保つためにBlackを使用することが推奨されている場合、この変更は再考するべきかもしれません。

- black-check:
- 	poetry run black --check $(CODE_DIR)
- 
- code-check: flake8-check black-check pre-commit-run
+ code-check: flake8-check pre-commit-run

@kyaukyuai kyaukyuai merged commit 597887d into main Mar 16, 2024
4 checks passed
@kyaukyuai kyaukyuai deleted the fix/makefile branch March 16, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant