improve error handling for loading config file #101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite
This change assume we can change
App::new()
to initialize logging earlier, since currently it is only initialized after Config is built as seen here:And it seems #99 should allow us to do so.
Overview of changes
Previously, errors when failing to read or parse the config. file were not logged. Errors in failing to read was also silently mitigated by defaulting to an empty string, which could lead to more problems down the road.
Users are still not notified directly (they will have to check the logs) when this happens, and I think that might be necessary?