-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: move all Lore specific modules to new
lore
lib module
[What] Create a module named `lore` in the library crate to house all domain-specific modules. This considerably cleans the `src/` directory, with the only con of adding another nesting level to the library crate and having to collaterally update a handful of imports. [Why/Context] Currently, the `src/` directory of the project is a mess as it is crowded with the modules defined in the library crate and the binary crate as well. Specifically, the modules from the lib crate (defined in `lib.rs`) are domain-specific, i.e., they represent implementations that are significantly or entirely coupled with the Lore objects and API. In this sense, we could extract every module from the library crate (at the moment, they all live directly in `src/`) to a directory `lib/`. This would result in a good clean-up, as all directories of these modules, like `lore_api_client/`, `lore_session/`, etc., would be encapsulated inside `lib/`, but the modules themselves (`lore_api_client.rs`, `lore_session.rs`), would still need to be directly under `src/`. Signed-off-by: David Tadokoro <davidbtadokoro@usp.br>
- Loading branch information
1 parent
55d2416
commit 324d0df
Showing
16 changed files
with
18 additions
and
15 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1 @@ | ||
pub mod lore_api_client; | ||
pub mod lore_session; | ||
pub mod mailing_list; | ||
pub mod patch; | ||
pub mod lore; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
pub mod lore_api_client; | ||
pub mod lore_session; | ||
pub mod mailing_list; | ||
pub mod patch; |
File renamed without changes.
2 changes: 1 addition & 1 deletion
2
src/lore_api_client/tests.rs → src/lore/lore_api_client/tests.rs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
use super::*; | ||
use crate::patch::PatchFeed; | ||
use crate::lore::patch::PatchFeed; | ||
|
||
#[test] | ||
#[ignore = "network-io"] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters