Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use lrucache for account store records #1333

Merged
merged 2 commits into from
Feb 3, 2025
Merged

use lrucache for account store records #1333

merged 2 commits into from
Feb 3, 2025

Conversation

charithabandi
Copy link
Contributor

No description provided.

@charithabandi charithabandi marked this pull request as draft January 31, 2025 22:31
@jchappelow jchappelow linked an issue Jan 31, 2025 that may be closed by this pull request
Fix ever-growing accounts map #1326
Closed
@charithabandi charithabandi marked this pull request as ready for review February 3, 2025 15:13
jchappelow
jchappelow reviewed Feb 3, 2025
View reviewed changes
Copy link
Member

@jchappelow jchappelow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except I think this needs tests to ensure the lru params are having the desired effect. Probably that means a new type to isolate, and use for the records, but that might be overkill as far as the product goes.

@charithabandi charithabandi merged commit ef37879 into kwilteam:main Feb 3, 2025
2 checks passed
@charithabandi charithabandi deleted the lrucache branch February 3, 2025 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jchappelow jchappelow jchappelow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix ever-growing accounts map
2 participants
@charithabandi @jchappelow